Product cart notification using flexbox and javascript

Community feedback

• 

  Daniel Perez Romo•70

  @Daniel77aprPosted about 2 years ago

  Hey, Miguel!

  I,ve had this problem before. Try using b.style.visibility!='visible' instead of b.style.visibility=='hidden' as the condition in your last function like this:

  cart.addEventListener('click', function hola(){
      b.style.visibility!='visible'? b.style.visibility='visible': b.style.visibility='hidden';
  });
  

  I'm not sure why (beginner here), but I have noticed that JavaScript does not recognize property values previously added in CSS, only the ones added in JavaScript. So basically, after loading the page with the previous code, b.style.visibility=='hidden' returns false, and when you click for the first time, b.style.visibility='hidden' is run. Now that JavaScript added the hidden value, b.style.visibility=='hidden' returns true when clicking a second time and b.style.visibility='visible' is run. The new code solves this since b.style.visibility!='visible' returns true after loading the page.

  Hope this helps!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0