Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Notification page

@Lordyner

Desktop design screenshot for the Notifications page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


How could I improve my css ? And also is my use of variable for fonts and colors good ?

Community feedback

Declan 220

@engelbrechtz

Posted

Hey, hows it going? 👋

Changes To Consider

  • Use sass variables not CSS variables since you're using sass.
  • Use variables for media queries
  • Make a separate file called _variables.scss to write and use variables from that file by using @import

scss variables

:root {
  $primary-red: hsl(1, 90%, 64%);
  $primary-blue: hsl(219, 85%, 26%);
  $white: hsl(0, 0%, 100%);
}

css variables

:root {
  --primary-red: hsl(1, 90%, 64%);
  --primary-blue: hsl(219, 85%, 26%);
  --white: hsl(0, 0%, 100%);
}

Use variables for media quries like this.

_variables.scss file

$phone: 760px;
$tablet: 1024px;
$desktop: 1920px;

main.scss file

@import '_variables.scss';

@media (max-width: $desktop) {
      margin: 3rem;
}

Overall, the project is completed, good job!

Regards, Declan

1

@Lordyner

Posted

@DevDeclann Hey man,

Thanks for your great advices. I will do that for the next challenges !

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord