Notification Page Main w/ Vanilla JS & SASS

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @mikej321!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Michael Johnson•970

  @mikej321Posted 9 months ago

  @danielmrz-dev Thanks for your suggestion, Daniel! I wasn't trying to center it, normally I do center it with flexbox but in the project files, it didn't seem centered to me so I didn't do it. Although looking at the project through a second lens, it does seem as though it would be centered if it were bigger :). Thanks very much for the suggestion, I need to change some things haha.

  Michael Johnson

  1