Notification page

Community feedback

• 

  Igo Brasil Monteiro•150

  @igomonteiroPosted almost 2 years ago

  Hi Kathryn, nice job!

  I noticed that there is a problem in your solution, the notifications counter can be negative when clicking on notifications that have already been marked as read. Try to implement some condition that doesn't let the counter be less than zero.

  Best.

  Marked as helpful

  0

  ---

  

  Igo Brasil Monteiro•150

  @igomonteiroPosted almost 2 years ago

  Other than that, add the "alt" attribute to your images, it's a good accessibility practice. Read more at: Image alt

  Marked as helpful

  0

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @igomonteiro Thanks, fixed it now :)

  0

  

  Igo Brasil Monteiro•150

  @igomonteiroPosted almost 2 years ago

  @KathrynDavies123 Nice Kathryn, just need one more fix now. If you click "mark all as read" then click in some notification that was unread, the counter is still couting to -1, -2, -3 and so on. Try to update the state to every notification. I guess you are updating the visual components but not the states.

  Marked as helpful

  0

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  @igomonteiro should be fixed now, I solved this by checking if the element has the class "unread" and only to run the function if it does. Is there a better way than this?

  0