Note card with conditional check IF

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Great submission! Your JS seems to be working well, and the form is well centered as well as responsive.

  I'd suggest avoid using alert('Please, select a note.'), as there as many issues with that. One of them being: "alert(...) as well as confirm(...) and prompt(...) can be useful for debugging during development, but in production mode this kind of pop-up could expose sensitive information to attackers, and should never be displayed." (source: https://rules.sonarsource.com/javascript/RSPEC-1442 )

  alert() also block the code execution and it is not something u might want. Instead try to disable the button until something is selected, or simply add an error message and display that below/above the button.

  Hope you find this feedback helpful!

  Marked as helpful

  0

  ---

  

  Tiago Ribeiro•80

  @TiagoRidevPosted over 1 year ago

  @visualdenniss thank you very much for the feedback. I didn't know about alert and prompt, your information was very important for me.

  Thanks.

  0