responsive website using CSS grid and flex

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS.

  • The breakpoint 1440px is too big to switch views, I'm using a computer and viewing the mobile view.

  Alt text 📷:

  • The alt attribute should not contain underscores or hyphens, it must be human readable and understandable.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here 📘.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Hanana•170

  @meantoesPosted almost 2 years ago

  @MelvinAguilar Hi! thank you so much for the feedback⭐ It is so much helpful and I'll definetly try to improve my code with it👩🏻‍💻

  1
• 

  Hanana•170

  @meantoesPosted almost 2 years ago

  updated-- using the feedback from @MelvinAguilar 🙇🏻‍♀️

  0