Not my best work

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, adluders! 👋

  Good effort on this challenge! 👏

  A few things I suggest are,

  • Making sure the navigation links in the footer of the page of the mobile layout are actually links by using the anchor tag to create them.
  • I think closing any other open submenus in the header of the page when another submenu is opened would be a good idea (rather than having them all open at the same time).
  • Adding some margin/padding around the paragraphs on the page so that there's some space between them and the edges of the screen in the mobile layout. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted over 3 years ago

  @ApplePieGiraffe thanks for the detailed feedback as always. And yeah I was being lazy 😂😂. After finishing the challenge I'm currently working on, I plan on refactoring this and three other projects that I submitted. Btw are you on slack? I would love to connect with you.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @adluders

  No problem! 👍 Yeah, I'm on the Frontend Mentor Slack community—feel free to DM me there @ApplePieGiraffe! 😀

  0
• 

  Youssef Mohamed Hassan•160

  @YoussefMohamed2k19Posted over 3 years ago

  Good Solution @adluders but you should decrease width of laptop image alt="laptop graphic" at responsive screens

  1

  ---

  

  Adler G Luders•1,580

  @just-a-devguyPosted over 3 years ago

  @YoussefMohamed2k19 the width of the image?

  0

  

  Youssef Mohamed Hassan•160

  @YoussefMohamed2k19Posted over 3 years ago

  @adluders yes

  0

  

  Adler G Luders•1,580

  @just-a-devguyPosted over 3 years ago

  @YoussefMohamed2k19 I think the laptop image should actually be gone on mobile. What screen size are you using?

  0

  

  Adler G Luders•1,580

  @just-a-devguyPosted over 3 years ago

  @YoussefMohamed2k19 NVM I see what you mean. 🤦🏾‍♂️

  0