Normal static site code with HTML, SASS, Grid and flex with BEM
Design comparison
Solution retrospective
I tried my best at this project. But a little bit design issue when device is too small. So, warmly welcome your feedback and suggestion. Thank you.
Community feedback
- @Da-vi-dePosted about 3 years ago
Hi Swan-Yee, it's a good result for this project, it would be perfect if only you would have followed mobile first aprroach.
-
On mobile it looks like this, because adjusting code from big width to small width it's a titanic challenge, it requires writing much more code, the techniques can't work properly unless you're very skilled and you know how to manage it. I strongly encourage you starting the mobile version first and then you write
min-width
breaking points! -
Also it would be better if you take care of code indentantion, if this project was bigger i would give up on taking a look at your html code, it's nearly unreadable! Each area can be separated by blank space and a comment on top; the eyes will thank you!
Hope it helps you, keep coding :-)
Marked as helpful2@developedBySwanPosted about 3 years ago@Da-vi-de Thanks for your time, I like your suggestions and I will follow next challenge. You give a lot of help.
Thank U :)
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord