@vanzasetia
Posted
Hello there! 👋
Congratulations on completing your first Frontend Mentor challenge! 🎉
Here are some recommendations for improvements.
- I recommend moving all the styling to a separate CSS file. It's not a big deal for this challenge however, it's best to practice this so that you start having a habit of doing this. 🙂
- I suggest removing the media query by finding an ideal value for the
margin
of thecontainer
. Maybe around1.5em
would be good for both desktop and mobile layout. - The QR code is an important image for this challenge so it needs an alternative text. Without alternative text, the image will not be pronounced by screenreaders.
That's it! I hope you find this useful! 🙂
Marked as helpful
@AtulKumar0001
Posted
@vanzasetia Hello Vanza Setia. Thank you for your reply. I appreciate your tips. I usually use style.css, but I was feeling lazy today, so I used internal CSS 😅, but I suppose having the habit of doing the styling on a separate CSS file is beneficial.