Design comparison
Solution retrospective
Please, I need feedback from my project.
Community feedback
- @MainlyColorsPosted over 3 years ago
your github pages is showing the readme instead of the index.html, I assume the reason is your files are inside a doc folder but you didn't link the github pages setup to that folder.
The SVG images could be linked with an
<img>
tag instead of using the raw SVG code. like below:<img src="./images/icon-sedans.svg" width="64" height="40" alt=""/>
In this example we use "./" in the beginning of the link to say current directory then the normal folder structure after that. This is called the relative path, its relative to the index.html file location.
Also look into semantic HTML, the accessibility report is yelling at you because it expects to find a
<main>
tag which defines the main content on the page for people that use screen readers.Hope this helps, keep putting that work inπ
Marked as helpful0@MatiasMassPosted over 3 years ago@ryan2505 Thank you very much for your feedback! It helps me a lot!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord