No additional tools, just VSC

Community feedback

• 

  Fluffy Kas•7,675

  @FluffyKas

  Posted over 3 years ago

  Hey,

  Good start on the challenge! I'd add a few things though:

  1. If you wanted to center your card, you could apply this to your body: min-height: 100vh, display: flex, justify-content: center, align-items: center. To make this work, you'll also need to remove that big margin-left on the main container. I'm also not sure adding a fixed height is necessary :)

  2. I think your card looks a bit better without that word-break. To be honest, I've never even saw that property before so I learned something new :)

  3. Your button uses the browser's default font-family, unless you set it specifically. Alternatively, you could use all: unset to get rid of browser defaults. It's also nice to add a fallback font-family in your code, like serif, sans serif, etc. Google fonts actually gives you the right piece of code when you import the font, I'd suggest using that ^^

  4. I'd encourage using relative units instead of pixels for a more responsive/accessible design (when applicable)!

  13

  Marked as helpful
• 

  Juveria Dalvi•1,375

  @Juveria-Dalvi

  Posted over 3 years ago

  Great work 👍🏻 add div with class attribution in between footer tag

  <footer>
  <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
      Coded by <a href="https://github.com/Scarab911">Paulius Bieliauskas</a>.
    </div>
  </footer>
  </body>
  

  11

  Marked as helpful