Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Moon-Seng, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - for fix the size of bg image add
background-size: contain
property - instead of using
px
try to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1@Moon-SengPosted over 2 years agoHello @denielden
Thank you for giving me some advice. It's really helpful for me. I really appreciated it. I hope that I can get more comments on my Future Project.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord