Nice 4 cards c:

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Eduardo! 👋

  Nice to see you complete another challenge (sorry—I only noticed your request for feedback on this solution just now)! 😀 Good job on this one! 👏

  I think you can move the <span> that contains the "Powered by Technology" text inside the <h1> (since they seem like they are part of the same heading).

  I'm also noticing a horizontal scroll bar that appears along the bottom of the page, for some reason. You might want to add overflow-x: hidden to the body or something to prevent that from showing up. 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hey

  This looks really nice and close to the design, well done.

  Its a real shame you've not used css grid for this though, it's so perfectly suited to it. Maybe try and refractor using grid so you don't lose the learning opportunity ☺

  And a note on this: width: 100vw; you don't need it and you will pretty much never want to have that in your css. Viewport units don't account for things like scrollbars which are inside the viewport, so you can end up creating horizontal scroll without meaning to. Width 100% is better, but remember you don't need that on the body or any block elements as they are full width by default anyway

  Good luck with your coding

  0
• 

  P

  Joel•290

  @joelsalmeidaPosted over 3 years ago

  You found an interesting solution to this challenge. Good work. Just a quick tip: You can add borders separately. e.g. border-top. I believe it would be simpler in this case.

  0