Design comparison
Solution retrospective
My third challenge posted, as always all feedback is welcome!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi, Eduardo! π
Nice to see you complete another challenge (sorryβI only noticed your request for feedback on this solution just now)! π Good job on this one! π
I think you can move the
<span>
that contains the "Powered by Technology" text inside the<h1>
(since they seem like they are part of the same heading).I'm also noticing a horizontal scroll bar that appears along the bottom of the page, for some reason. You might want to add
overflow-x: hidden
to thebody
or something to prevent that from showing up. πKeep coding (and happy coding, too)! π
0 - @grace-snowPosted over 3 years ago
Hey
This looks really nice and close to the design, well done.
Its a real shame you've not used css grid for this though, it's so perfectly suited to it. Maybe try and refractor using grid so you don't lose the learning opportunity βΊ
And a note on this:
width: 100vw;
you don't need it and you will pretty much never want to have that in your css. Viewport units don't account for things like scrollbars which are inside the viewport, so you can end up creating horizontal scroll without meaning to. Width 100% is better, but remember you don't need that on the body or any block elements as they are full width by default anywayGood luck with your coding
0 - @joelsalmeidaPosted over 3 years ago
You found an interesting solution to this challenge. Good work. Just a quick tip: You can add borders separately. e.g.
border-top
. I believe it would be simpler in this case.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord