@PhoenixDev22
Posted
Hello Simen Hagen,
Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:
HTML
- The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you (not describes the image).
- For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in( icon-ethereum, icon-clock ).
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<hr>
, you can useborder-top:
to the avatar's part.
- Adding
rel="noopener"
orrel="noreferrer"
totarget="_blank"
links. When you link to a page on another site usingtarget=”_blank”
attribute , you can expose your site to performance and security issues.
Hopefully this feedback helps.
Marked as helpful
@SimenHagen86
Posted
@PhoenixDev22 Thanks for the tips and feedback! was your solution that helped me get the preview to show right:) made me scrap the first one that i had images instead of anchors.
ill make sure too read up on this.
@PhoenixDev22
Posted
@svimen86 Glad to help. Happy coding!