nft-preview-component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  Hello Elena, congratulations for your solution?!

  Your component is perfect, but is not responsive yet, this is due the fixed width you've applied to the container. Look both width and max-width the main difference between these properties is that the first(width) is fixed and the second(max-width) is flexible, for example, a component with width: 340px will not grow or shrink because the size will be ever the same, but a container with max-width: 340px or min-width: 340px can grow or contract depending of the property you've set for the container. So if you want a responsive block element, never use width choose or min-width or max-width.

  .product-card { 
  MAX-WIDTH: 340PX;
    /*   width: 350px; */
       height: 596px; 
       margin: 152px 545px; 
       padding: 24px 24px 270px 24px; 
       text-align: left; 
       box-shadow: 0px 25px 50px rgba(0, 0, 0, 0.0952917); 
       border-radius: 15px; 
       background: var(--Very-dark-blue-card); 
       position: relative; 
   }
  

  Hope this helps, happy coding!

  Marked as helpful

  1

  ---

  

  Elena•60

  @ElenaKondrashovaPosted about 2 years ago

  @correlucas Hi Lucas, thanks so much for your suggestion! I made some changes, and I think I've achieved some responsiveness now. Do you find it's best to code mobile first, and then expand to desktop via media query, or either way works fine?

  0

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @ElenaKondrashova yes it's a best practice start by mobile since the majority of person access websites by mobile devices. By the first its kinda hard, but with some practice you get use to.

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Elena,

  Congratulation on finishing this challenge. Great job on this one! I have few suggestions regarding your solution:

  HTML

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a>to wrap Equilibrium #3429 and Jules Wyvern too.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • The link wrapping the equilibrium image (image-equilibrium) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be Designer's avatar. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Elena•60

  @ElenaKondrashovaPosted about 2 years ago

  @PhoenixDev22 thanks so much for your detailed comment! Although I'm yet to try implementing suggested changes, this feedback is really helpful. I appreciate your time.

  0