nft-preview-card-react

Community feedback

• 

  P

  Robert McGovern•1,075

  @tarasisPosted about 2 years ago

  Hi Nutchapon, congratulations on completing the challenge 🎊 Looks good, and works for both desktop and mobile. As I don't really know react I can't comment on the build of your solution.

  Be careful with the CSS, for instance the root doesn't need the max-width: 1440. The only thing that needs a max-width would be the card itself.

  Also for your link hover's you used color: hsl(178, 100%, 50%) !important;. Don't use !important if at all possible. Its a last resort. As it is, your hover solution for a tags works without it.

  The text-rendering: optimizeLegibility; is new to me, so cheers for that. However as far as I'm aware font-weight: 300, 400, 600; doesn't mean anything. The weights are imported when you import the font. You then just use the font-weight you need for a particular block of text (like the heading being 600) https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

  Marked as helpful

  0

  ---

  

  Nutchapon Makelai•270

  @kodaicoderPosted about 2 years ago

  @tarasis , about !important I forgot to removing it out , so shame on me :(
  and text-rendering: optimizeLegibility; it is coming on I create a project via Vite ,I didn't removing it so far.

  but thanks a lot on max-width and font-weight I will keep that comment and improving it in next project :)

  0