nft-preview-card-component-main

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Midnith,

  Great work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • The link wrapping the equilibrium image (image-equilibrium ) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-ethereum, icon-clock).

  • You can use unordered list<ul> to wrap class="price". In each <li> should be <img> and <p>, then you may use flex properties to align them centrally.

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • The alternate of the avatar image should not be avatar picture, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text .

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Aside these, good job on this one. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Midnith•120

  @MidnithPosted about 2 years ago

  Wow! Thank you so much @PhoenixDev22 That was really helpful. I've added the interaction that I just completely forgot and fixed almost everything. Just one question about your comments: why it's better to use border-top on the avatar's div instead of using a proper separator <hr>?

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Congrats on completing this challenge!

  To answer you question, the way you did it is correct; It just needs some cleaning up. You can try this:

    <div class="addtional-info">
          <div class="price">
            <img src="" alt="" />
            <p></p>
          </div>
          <div class="time">
            <img src="" alt="" />
            <p></p>
          </div>
        </div>
  

  0
• 

  P

  Jake Godsall•1,390

  @jakegodsallPosted about 2 years ago

  Hi,

  Not exactly the most insightful comment but there is no wrap when loading the live site on my machine, nor on my phone. Tried playing around with different viewport sizes and it always seems to maintain a single line.

  Not quite sure what is going on here.

  0

  ---

  

  Midnith•120

  @MidnithPosted about 2 years ago

  Hi @jakegodsall Thanks for your feedback. Apparently, the wrap only appears on Firefox, but I can't figure out why.

  0

  

  P

  Jake Godsall•1,390

  @jakegodsallPosted about 2 years ago

  @Midnith Not exactly sure of the reason behind this. Perhaps someone else can give more insight on the differences between browsers.

  However, in the meantime, a quick and dirty fix would be to manually increase the width of the p tag that your "3 days left" sits inside.

  100px seems to do the trick.

  Marked as helpful

  0