Skip to content
Submitted over 1 year ago

nft-preview-card-component-main with Grid Flex ...

DESELMAAR•280
@DESELMAAR
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any suggession will be welcome , thank you in advance.

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨ Remove all margins from .container its not a good way of centering card.

    • To properly center the container.

    • USING FLEXBOX

    body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
    • USING GRID
    body{
min-height: 100vh;
display: grid;
place-items: center;
}

    ➨ For image like .svg are decorative which screen reader will not render it to be important and skip it, so it make no sense to add alt leave it blank.

    ➨ Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>

    ➨ Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    link.

    ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

    I hope you find this helpful.

    Happy coding😄

    Marked as helpful
    0
    DESELMAAR•280
    @DESELMAARPosted over 1 year ago

    @NehalSahu8055 thank you a lot for the great insights , I will surly use these nice skills :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord