nft-preview-card-component-main

Community feedback

• 

  Mariana Ramos•50

  @mariana-c-ramosPosted over 2 years ago

  Hello @alaayasser741!

  Just a quick tip: about the headings, we should always use them from h1 up to h6, without skipping any and without going back and forth between them in the same section tags. What does this mean?

  For example, if you open a section/div tag for the hero and use a h2, you can only use it again if you open a whole new section/div tag (can't be nested). And if you used an h3 for example you can't go back to another h2 - only in a new section/div.

  It appears here in your project you skipped the h2, change each h3 to an h2 and it should be fixed! Hope this helps, even if just a little! :)

  Marked as helpful

  1

  ---

  

  Alaa Yasser•260

  @alaayasser741Posted over 2 years ago

  @mariana-c-ramos Thanks this was helpful :)😅

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Alaa, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • To make it look as close to the design as possible set width: 22rem to box class
  • remove all margin from box
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  1

  ---

  

  Alaa Yasser•260

  @alaayasser741Posted over 2 years ago

  Thanks I'll do that @denielden

  1