nft-preview-card-component-main

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Nassim,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative svgs, each svg tag should have aria-hidden="true" and focusable=”false” attributes to make all web assistive technologies such as screen reader ignore those svgs in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • For middle part of the card class="card__balance-container", you can use an unordered list <ul>, in each <li> there should be <svg> and <p>. That way you can align them centrally.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view doesn’t really need to be in the HTML. You can use CSS for it.

  Overall, Your solution is good. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Nassim•200

  @Nassim555Posted over 2 years ago

  @PhoenixDev22 thank you so much for this comment i has a lot of information and some new attributes that i've never heard of before which i'll definitely look into thank you again

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @Nassim555 Glad to help. Happy coding!

  1
• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello Nassim congrats on finishing the challenge!

  If you don't mind I would like to give you a little suggestion.

  You don't need to use margins on your main tag to center it, you are already calling flex-box in your body, so take advantage of that and use justify-content: center and align-items: center in your body, if you want to get some separation between the footer and the main, you can also use gap in your body instead of margins!

  Hope my feedback helps you!

  Marked as helpful

  0

  ---

  

  Nassim•200

  @Nassim555Posted over 2 years ago

  @DavidMorgade Hi david , thank you for your suggestion i wonder how would i push the attribution in case i used align-items justify-content, or can i use margin-top:auto on the attribution would that work ?

  1

  

  David•8,000

  @DavidMorgadePosted over 2 years ago

  @Nassim555 Yo can use position: absolute bottom: 1rem to push it to the bottom

  Marked as helpful

  0