nft-preview-card-component-main

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> And remove the text from the foooter

  Keep up the good work!

  0
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @khanisrar ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • On smaller devices, card goes over screen, and I think max-width: 100% can solve this issue.
  • Please try BEM for naming element classes. It will help you a lot on bigger projects.
  • There is no hover effects on image and other elements. It's also one of challenging part here.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  0
• 

  Aditya Singh•460

  @adityas24Posted almost 3 years ago

  Hey Israr Good Job ! And it's not a landing page buddy.

  0