Design comparison
Solution retrospective
how can i set hover{ transition:0.3s} to before and after class. all feedback is welcome
Community feedback
- @PhoenixDev22Posted over 2 years ago
Hello Abdelrahman Khaled,
Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:
HTML
- The most important part in this challengeinteractive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
1: If clicking the image would show a popup where the user can see the full NFT, here you use<button>
. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use<a>
.
- The link wrapping the equilibrium image should either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you.
- For any decorative images, each img tag should have empty
alt=""
and addaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in( icon-ethereum, icon-clock ).
- The alternate text should not be hyphenated, it should be human readable.
- Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be
personal-img
, it’s meaningless. You can use the creator's nameJules Wyvern
. Read more how to write an alt text
- If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the
<hr>
, you can useborder-top:
to the avatar's part.
- Never use
<div>
and<span>
alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.
- For middle part of the card
class="detel"
, you can use an unordered list<ul>
, in each<li>
there should be<img>
and<p>
. That way you can align them centrally.
- There are so many ways to do the hover effect on the image, The one I would use is pseudo elements
::before, ::after
. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.
Overall, Your solution looks great. Hopefully this feedback helps.
0 - The most important part in this challengeinteractive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..)
for this imagine what would happen when you click on the image, there are two possible ways:
- @elaineleungPosted over 2 years ago
Hi Abdelrahman, about your question on the overlay, you can just use
transition
with the property you want changed, and then add a:hover
pseudo class with that property. For instance, to make the overlay, I used opacity, and in my hover changed, I changed the opacity property, like this:.overlay { position: absolute; width: 100%; height: 100%; top: 0; left: 0; z-index: 1; background-color: hsla(178deg, 100%, 50%, 0.5); opacity: 0; display: grid; place-content: center; transition: opacity 200ms ease-in-out; } .card__image .overlay img { width: 3rem; height: 2rem; } .card__image .overlay:hover { opacity: 1; }
You can check out my solution here and see whether that helps: https://www.frontendmentor.io/solutions/reponsive-nft-preview-component-W2gWx-dAyA
Good luck!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord