
Design comparison
Solution retrospective
All feedback are welcome. Thank you in advance
Please log in to post a comment
Log in with GitHubCommunity feedback
- @Algka
Thank you for our suggestions. I like more that
- @0xabdulkhaliq
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
.rectangle { margin-left: 550px; margin-top: 100px; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
- @devjhex
@Algka You have done a very great job on this component, It shows that you put in a lot of effort completing it, Well done. I hope this suggestion would help in the positioning of the component in the center of the page.
body{ background-color: var(--Very-dark-blue1); display: flex; justify-content: center; align-items: center; flex-direction: column; height: 100vh; }
Otherwise, you have done an excellent job. Keep up with the code!!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord