nft-preview-card-component-main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Jonatan, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • remove margin and top properties from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-heigth: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  0

  ---

  

  Jonatan Morales•240

  @DevJonatanMoralesPosted over 2 years ago

  @denielden Hello, thank you very much for the observations, they have helped me a lot, do you have any advice to name the classes?

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @DevJonatanMorales You are welcome! try to use names that describe what the class is for

  Marked as helpful

  0