Design comparison
SolutionDesign
Community feedback
- @0xabdulPosted over 1 year ago
Hello there well congrats on completing the NFT card component 🤩
- A Few feedback for improve your code 📝
- In Html 🏷️ :
- the html documents must be contained one level heading Ex :
<h1><h2> <h3><h4>ect.. well using heading line by line or sequence way - Ex :
<h1>Equilibrium #3429</h1> <p>Our Equilibrium collection promotes balance and calm.</p> <p> 0.041 ETH</p> <p> 3 days left</p> <p>Creation of Jules Wyvern</p>- like this don't sikp this
- The Main landmark♦️
- th html page should be contained one main landmark so fix them
- to clear the Accessibility reports using semantic elements or non semantic elements
- for easy way to clear the all Accessibility reports using non - semantic elements Ex :
<div> , <span> - let's try
- Ex :
<body> <div class="container" role="main"> //Html code here 🏷️ </div> </body>- OR
- using semantic elements Ex :
<aside> <section> <main> <nav> <header> < footer> - Ex :
<body> <header>company logo header name...</header> <main> the main content here</main> <footer>@Copy right Here</footer> </body> </html>- I Hope you find the solution and it's useful for you 😀
- Happy Coding
Yashraj Dudhatra🤩
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord