NFT-Preview-Card-Component-Frontend-Challenge

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @d0nchian, some suggestions to improve you code:

  • Stay away from IDs when naming your content. They are not reusable and are mainly used for JavaScript. Its best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling.

  • The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The Section Elements are being used incorrectly and not needed for this challenge.

  • The Icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  donchian•190

  @d0nchianPosted about 2 years ago

  @vcarames Thank you so so much for the feedback you gave me! Hope you keep giving me feedback on all my submissions so i can improve faster! <3

  0