@maciejkrol18
Posted
The 'attribution', or 'attribute' as you referred to it, is something you'll find pre-written in the HTML file of every Frontend Mentor project. It's just a suggested way of signing your work, so to speak. You can delete / comment it out if you want.
As for your code, it's pretty readable, although i've got some suggestions for you to consider:
- Why not simplify that article tag on line 37 in your .html file? It's not really readable when everything's on the same line.
- Remove the default margin from your body tag (add
margin: 0
) and addmin-height: 100vh
to it. The vh unit means viewport height, so your body tag will take up the entire screen, which makes the card properly centered. - Some of your CSS variables are lowercase and other ones are camel case. You should make it consistent by picking one of the two. On the topic of variables, what is that
margin: 0
andpadding: 0
in the :root? - I'm not really sure about that
<ul>
tag used in the nft's price and days left. I would replace it with simple flex container.
That's all i could think of for now. Overall, good job on your first project!
Marked as helpful