nft-preview-card-component using Sass

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted over 2 years ago

  Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…

  • To understand more about the hero image hover state, refer it with this example Overlay in Image (If this is still applicable)
  • This line <div class=" attribution"> can be wrap with footer tag or placed it inside the main tag
  • Clean the whitespaces in the code
  • Adjust the margin in main #card ruleset into margin: 10rem auto; and remove the margin placed on the media query
  • Add cursor: pointer for the hover state of the design
  • Increase the font size of h1 into font-size: 22px;

  In the brighter side...

  • Well done with the hover state of the design, specially the hero image
  • The project is responsive and utilized the details based on the original design
  • Great job in using Sass for styling, the compositions are well organized
  • The HTML structure is well organized and readable

  Above all, The project is awesome! Keep it up!

  1

  ---

  

  Efosa Collins EVBOWE•365

  @efecollinsPosted over 2 years ago

  @RioCantre Thank you very much, Rio Cantre. I really appreciate it, your comment just lifted my spirit. I'll do well to make the changes you've advised me to. Thanks once again.

  0