nft-preview-card-component using HTML AND CSS

Community feedback

• 

  Jeremiah Aworetan•90

  @jeremy0xPosted over 1 year ago

  Hi @Dng120696,

  Great work on the design! 👍

  I noticed that when you hover on the .container-img to show the .hover-img, the .equi-img doesn't take up the full height of its container. I had a similar issue before, and here's a possible fix:

  • Give .container-img a height, then set the image to have a height of 100%.
  • You can also add object-fit: cover; to the image, so it covers the container completely.

  Keep up the good work! 😊

  Marked as helpful

  0

  ---

  

  Christian Patrick Nebab•1,080

  @Dng120696Posted over 1 year ago

  @jeremiey ok got it thank you

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution has generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0