nft-preview-card-component using flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  CSS 🎨:

  • We want to Use min-height: 100vh instead of height.

  ---

  • Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  ---

  • So change, the following style rule

  body {
      height: 100vh;
  }
  

  ---

  • To this,

  ---

  body {
      min-height: 100vh;
  }
  

  I hope you find it helpful ! 😄 Above all, the solution you submitted is great

  Happy coding!

  0