nft-preview-card-component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • Page should contain a level-one heading. In this challenge , as it’s not a whole page, you can have<h1> to wrap the Equilibrium #3429.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason , you can use <a> to wrap Equilibrium #3429.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in ( icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be image-avatar, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • The alternate text should not be hyphenated, it should be human readable.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card .metadata, you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view doesn’t really need to be in the HTML as there is no need for an extra clutter in the HTML.

  Aside these, Great job on this one. hopefully this feedback helps.

  Marked as helpful

  0
• 

  Eduardo•910

  @KTrick01Posted about 2 years ago

  Hi! Another way of doing the overlay is with an : after or ::before pseudo element, here is a little example that I did using your classes:

  .image-container::after {
    content: "";
    position: absolute;
    inset: 0;
    background-color: #ff000057;
    opacity: 0;  
    transition: .3s;
    border-radius: .5rem;
  }
  .image-container:hover::after {
    opacity: 1;
  }
  

  When I did this challenge the overlay was the hardest thing for me too, so I hope that it helps you. Try it and see if you like it! (You can put the eye icon as the background-image of the pseudoelement)

  Marked as helpful

  0

  ---

  

  Dean Russell Rivers•40

  @deanriversPosted about 2 years ago

  @KTrick01 Thanks for the tip! Definitely better than incuding JS unecessarily.

  0