Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

nft-preview-card-component

Eyu32ā€¢ 140

@Eyu32

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'd really appreciate if I could get your feedback on my work.... thank you

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello @Eyu32!

Your solution looks excelent!

I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <p>. Unlike what most people think, it's not just about the size and weight of the text.

šŸ“Œ The <h1> to <h6> tags are used to define HTML headings.

šŸ“Œ <h1> defines the most important heading.

šŸ“Œ <h6> defines the least important heading.

šŸ“Œ Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, you did a great job!

Marked as helpful

1
Marcos Travagliniā€¢ 4,920

@Blackpachamame

Posted

Greetings! you have done a great job šŸ˜Ž

šŸ“Œ Some suggestions

  • The text "Equilibrium #3429" could be an h1 or h2 header instead of a p
  • The image is part of the card, so you should not place it as a background, but as another element of the card. Plus, it's much simpler than what you did.

Marked as helpful

1

Eyu32ā€¢ 140

@Eyu32

Posted

@Blackpachamame thank you for your feedback........ b't how can i put the image as apart of my card while i use it as a background....?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord