nft-preview-card-component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @Eyu32!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <p>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  1
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some suggestions

  • The text "Equilibrium #3429" could be an h1 or h2 header instead of a p
  • The image is part of the card, so you should not place it as a background, but as another element of the card. Plus, it's much simpler than what you did.

  Marked as helpful

  1

  ---

  

  Eyu32•200

  @Eyu32Posted 10 months ago

  @Blackpachamame thank you for your feedback........ b't how can i put the image as apart of my card while i use it as a background....?

  0