NFT-preview-card-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ambrolla, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • To make it look as close to the design as possible remove height to main class and set padding: 1rem
  • remove height and margin-top properties from .image class
  • remove all margin from main tag and padding-top from body
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-heigth: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • after, try to add a little transition on the element with hover effect

  Overall you did well :)

  Hope this help and happy coding!

  1