nft-preview-card-component

Community feedback

• 

  Bruno Pinho•80

  @pinhobPosted over 1 year ago

  Hi, Gustavo! Great work finishing the challenge! 🚀

  I have a few suggestions for you of things that I found helpful doing my solution for this challenge:

  • I like your approach to the hover effect in the NFT image, but try to use width: 100% in the .imgNFT class. This will make your image responsible and also the same size as the ::before and ::after elements.

  • You can remove the height of the <main> component, or use min-height: 60vh instead of height: 60vh. This way, the element will grow to fit all the children's content. You can see more about the min-height property here, it's really helpful in some cases.

  • Take a look at the BEM methodology to name classes. It's a great way to choose how to name our classes, in my opinion! (If you want a really good video in Portuguese, watch this one)

  I hope you find theses tips helpful.

  Congrats again for the challenge and happy coding! 🤓

  1

  ---

  

  Gustavo•70

  @gunney69Posted over 1 year ago

  Thanks for support @pinhob

  1

  

  Bruno Pinho•80

  @pinhobPosted over 1 year ago

  Anytime, @gunney69!

  1