nft-preview-card-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Mazinger, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • add margin: 0 to body to remove the side scroolbar of browser
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0

  ---

  

  Daniel Lasauskas•230

  @mazinger086Posted about 2 years ago

  @denielden Thanks for your reply, I'll apply your improvements ideas 😉

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @mazinger086 You are welcome and keep it up :)

  0