NFT-preview-card-component

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .container {
  margin: auto;
  margin-top: 100px;
  margin-bottom: 20px;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• Account deleted

  Wow your solution is great

  And I have a small suggestion for you that might be helpful for you

  card is not centered :

  Looks like your card is not centered properly and you can center it by writing

  body{
  
  display: flex;
  justify-content: centre;
  align-items: center;
  min-height: 100vh;
  
  }
  

  And than remove these styles from your CSS

  .container{
  margin: auto;
  margin-top: 100px;
  margin-bottom: 20px;
  }
  

  Marked as helpful

  1

  ---

  

  UbaidRussell•140

  @UbaidRussellPosted over 1 year ago

  .@MrSandipSharma , Thanks bro the site looks even better now, didn't really pay attention to the small detail however that small detail really did change how the site looks as a whole, I appreciate your feedback.

  0