Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Balogun, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - to make it look as close to the design as possible add
border-radius: 1rem and overflow: hidden
tomain-image
class - remove all
margin
fromcontainer
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
Marked as helpful1@Balpos07Posted over 2 years ago@denielden Thanks 😊. So much appreciate your comment and advise, they are very helpful and needful for my growth and development
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord