nft-preview-card-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Balogun, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • to make it look as close to the design as possible add border-radius: 1rem and overflow: hidden to main-image class
  • remove all margin from container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Balogun Ayomiposi Israel•50

  @Balpos07Posted over 2 years ago

  @denielden Thanks 😊. So much appreciate your comment and advise, they are very helpful and needful for my growth and development

  1