NFT-preview-card-component

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted almost 3 years ago

  1- Equilibrium #3429 would better be described by a heading element rather than a paragraph.

  2- Author names should be wrapped inside a link because the interactive nature of it, it is expected to take the user to author's page upon clicking.

  3- A general tips, always use transition for interactive sections of your solutions. For one thing it feels more natural to user and for the other it improves UX.

  Keep coding :=)

  1

  ---

  

  Gaurav Kumar•570

  @GauravkumarioPosted almost 3 years ago

  @MojtabaMosavi thank you for great tips

  0
• 

  Martin Eliáš•890

  @martinelias1312Posted almost 3 years ago

  Hello, my few suggestions:

  • for better accessibility alternate text in <img> elements should have descriptive text of what is on the picture. But if the picture is only decorative alternate text can be blank - alt=""
  • for positioning your NFT card u can use this instead of absolute positioning:

  body {
  display: flex;
  justify-content: center;
  align-items: center;
  height: 100vh;
  }
  

  Hope this tips will help for next challenge :)

  1

  ---

  

  Gaurav Kumar•570

  @GauravkumarioPosted almost 3 years ago

  @smradupan thank you for suggestions

  0