NFT-preview-card-component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Hello @khshakib ,

  I have some suggestions regarding your solution:

  • First of all , I would suggest to have a separate file for the styles.

  • The element footer must not appear as a descendant of the header element.(no need for header here )

  • There should be two landmark components as children of the body element - a main (which will be the NFT card ) and a footer (which will be the attribution).<Footer> should be in the <main >read more about A simplified web page, might look something like this:

    • Anything with a hover style in a design means it's interactive. you need to add an interactive element<a> around the image Equilibrium #3429, Jules Wyvern and the hover effects on them.

  • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in( icon-view, icon-ethereum, icon-clock ).

  • the avatar 's alt shouldn't be avatar , you can set to Jules Wyvern.

  • the link should be wrapping the original image and either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • You can use an unordered list<ul> to wrap class="details"and in each <li>, there would be <img > and<p> (to wrap the text ). Then you can use flexbox properties to align them centrally.

  • Read more how to write an alt text

  • For this part don't use span for meaningful elements, it would be better like this :

        <div  class="">
          <img src="images/image-avatar.png" alt="">
        <p class="primary"> Creation of <a class="main">Jules Wyvern</a> </p>
        </div>
  
  

  • No need for this <hr class="line">, you can use border-top to the avatar's part.

  • I recommend to use em and rem units .Both em and rem are flexible, Using px won't allow the user to control the font size based on their needs.

  • Never use px for font size.

  • width: 350px;;an explicit width is not a good way . Remove the width from the main component and change it to max width instead. That will let it shrink a little when it needs to.

  • In height: 100vh;, better use min-height: 100vh; allow the body to set a minimum height value based upon the full height of the viewport. This also allows the body to to grow taller if the content outgrows the visible page.

  You might have a look at my solution , to see how I did the hover effect on the image , it might my helps.

  Overall, your solution is good, Hopefully this feedback helps.

  Marked as helpful

  0
• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Congratulation 😊🚀 complete the course Reduce the accessibility change the course - change this code

  ```<footer class=footer>` to <footer>`` ( Used only Footer tag for footer design)

  0
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • reset the body margin to 0
  • you can add the image and background color on hover with pseudo elements :before & ::after if you are not sure what i am talking about you can learn from my example

  i hope this is helpful and goodluck!

  0