nft-preview-card-challenge-03

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @m07mmad-nasr!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <span>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  1
• 

  P

  solvman•1,650

  @solvmanPosted 10 months ago

  Great jot!👍🚀

  I suggest using the <article> instead of <section> tag. In general, if the content makes sense on its own and could be syndicated, use an <article>. If the content is related but doesn't make sense on its own (it's part of a larger whole), use a <section>. In this instance, the NFT card looks to me to be a stand-alone unit, and the use of <article> is appropriate.

  In addition, consider using the <p> element instead of <span>. Remember that <p> is a block-level element, and <span> is an inline container. In general, use <p> for paragraphs of text, whether they consist of one sentence/phrase or multiple, and <span> for small chunks of HTML inside a paragraph or other block-level element.

  Congratulations!🎉🎊 Very well done!🚀

  1

  ---

  

  m07mmad-nasr•160

  @m07mmad-nasrPosted 10 months ago

  Thank you ❤@solvman

  0