Design comparison
SolutionDesign
Solution retrospective
What could I improve me code(am I missing the best practices)?
What skill or aspect of my code should I work on(resource, communities, etc. are all welcome)?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
body { min-height: 100vh; justify-content-center; align-items: center; }
- Now remove these styles, after removing you can able to see the changes
#background { padding: 60px; } #the-card { margin: 0 auto; }
- Now your component has been properly centered
BROKEN iMAGES 📸:
- We can quickly resolve it by adding
./
a period infront of path variables
- Eg:
src="./assets/image-avatar.png"
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@chr1swillPosted over 1 year ago@0xAbdulKhalid
Thank you very for you feed back, I will make those interactions ASAP.
Enjoy your day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord