Nft-preview-card using Sass and BEM

Community feedback

• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  To get rid of the accessibility/HTML issues shown in your Report:

  • have at least one <h1> in your code
  • <section> and <article> usually need a heading; so if you don't need a heading in it, use some other element such as <div>

  Good job! :)

  Marked as helpful

  1

  ---

  

  Max Sauerbrey•100

  @MaxSauerbreyPosted almost 3 years ago

  @anoshaahmed Hi Anosha! I appreciate you so much for you usefull answer. I will definitely put these tips into practice :)

  1
• 

  Dominik•130

  @Dmnk28Posted almost 3 years ago

  Hi Max, Looks great! Your scss-file is very clean and easy to read. I might adapt one or two aspects of your writing style ;)

  As the report indicates I would suggest to switch the html lang-attribute to "en" and to replace &--title (in &_text < .card) through an h-element. Both for SEO-reasons mainly.

  The HTML is commented throughout. There are different approaches on commenting, I know, but in my eyes it tends to over-commenting. Choosing class-names so that they refer to the purpose of the element (you did that already) and only commenting that elements, which aren't easy to understand. Comments should be descriptive and not redundant (e.g. <footer class="attribution">...). The structuring character of a redundant comment could be compensated with a simple blank line.

  Marked as helpful

  1

  ---

  

  Max Sauerbrey•100

  @MaxSauerbreyPosted almost 3 years ago

  @Dmnk28 Hi Dominik! Thank you for your kind feedback and I appreciate you so much for going over my code!

  0