Skip to content
Submitted almost 3 years ago

NFT-PREVIEW-CARD solution

Mikhael Opeyemi-Olatunjiβ€’150
@mikhael-oo
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please provide general feedback on what I could do better in this project. I just started with web development and it would do me a ton of good to know how I could better grow in my journey of learning. Thank you.

Community feedback

  • Fernando FeNβ€’425
    @Fernando0654Posted almost 3 years ago

    πŸ‘‹ Hey! I saw you used max-width property with %. This isn't a good idea because it will get smaller on smaller screen sizes. The best way of doing this is:

    max-width: 600px and width: 95% for example. This way, it's not gonna grow more than 600px on bigger screens and it'll be 95% on any kind of mobile device

    Good luck, browww.

    Marked as helpful
    1
    Mikhael Opeyemi-Olatunjiβ€’150
    @mikhael-ooPosted almost 3 years ago

    @Fernando0654 ah thanks. I also thought of using media queries but your suggestion might be the better option.

    1
  • Anosha Ahmedβ€’9,300
    @anoshaahmedPosted almost 3 years ago

    To get rid of the accessibility/HTML issues shown in your Report, wrap everything in your body in <main> OR use semantic tags OR give role="" to the direct children of your <body> ... Click here to read more

    Good job! :)

    Marked as helpful
    0
    Mikhael Opeyemi-Olatunjiβ€’150
    @mikhael-ooPosted almost 3 years ago

    @anoshaahmed Thank you!!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord