NFT-Preview-card component

Community feedback

• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Nice work man. Keep it up

  0
• 

  learningtogetherua•230

  @learningtogetheruaPosted almost 3 years ago

  Hi! Good job. I advise you not to use a vertical flex scheme in this task. Use bottom margins

  0

  ---

  

  Akinyemi Habeeb Aremu•150

  @Akinyemi4Posted almost 3 years ago

  @learningtogetherua Thank you very much.

  How do I add a vertical flex scheme?Can you kindly explain further?

  0

  

  learningtogetherua•230

  @learningtogetheruaPosted almost 3 years ago

  @Akinyemi4 display:flex by default has the flex-direction parameter set to row, which is why block elements inside a flex container are arranged in a row. You can specify a flex direction with a column value, the elements will return to a vertical position, but they can be distributed with the usual flex properties Try learn flex https://flexboxfroggy.com/

  0
• 

  Lorenzo Franco•480

  @LfrancosPosted almost 3 years ago

  Hello Akinyemi!

  This is looking really good, congratulations!!

  There is something that is happening and it used to happened to me as well and it is that if you scale your screen up (meaning changing the height of the screen) you will see that half of the card is missing and even if I try to scroll up I'm not able to see what you have there. I encourage you to use in your body element "min-heigth: 100vh" instead of what you have that is "height: calc(100vh - 1px);". You will see that this is going to help you with that problem.

  The last thing is that for accessibility you should add an element that has meaning for the the search engine. For this exercise I think you could use the element "main" that way the search engine would know that this is the main content and will know what your website is about.

  Hope this helps : )

  0

  ---

  

  Akinyemi Habeeb Aremu•150

  @Akinyemi4Posted almost 3 years ago

  @Lfrancos Thank you very much.

  0