Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT-PREVIEW-CARD CHALLENGE

@wolecodes

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


mY SUBMISSION FOR NFT PREVIEW CARD

Community feedback

@clinto-bean

Posted

Good work on the positioning and styling. A couple of pieces of feedback.

  • On the main card itself, the entire thing has cursor: pointer, so even if you are not hovering over an interactive element (i.e. just the text within certain sections), it has a cursor. This indicates to the user that it is interactive when it is not. You are better off declaring cursor: pointer; on the hyperlinks themselves (using the a{} styling in CSS) and doing the same for the .image-container.

-- Within the .image-container, you have the following code:

.card .image-container:active::after{

display: block;

}

you don't necessarily need to add .card before this as you are already referencing the .image-container itself. You don't have to reference parent elements unless you are trying to override other specificity.

--- You also will want to add a hover state to the image container. You can do both with one CSS code block by using a comma between selectors. See below.

.image-container:active::after,

.image-container:hover::after {

display: block;

}

Let me know if this comment was helpful. Good job on completing the challenge and keep up the good work!

0

@wolecodes

Posted

@clintonclark1995 Thank you for the feedback, and I have made the necessary changes, and which was really a good one and well noted. and thanks for the heads I will do better next time. mind if I connect with You?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord