Design comparison
Solution retrospective
Hello, I am fairly new to programming and would appreciate any tips and advice to help improve my code.
Community feedback
- @Jorgus1710Posted over 2 years ago
Hey! Good try on the challenge, it can be intimidating to start so honestly good for you for taking on the challenge. I'm not an expert by any means, but I have some suggestions which may help you.
For starters, your index.html has some things which need to be looked at. Your general structure seems to be laid out in a logical manner, but when you look closer you will notice you are missing some closing tags on your divs, which can make everything misbehave once you get to working on styling in CSS.
Line 27: <div class "details"> for example has no closing tag. Line 36: <div class "creator"> also has no closing tag.
Generally speaking just go over you're structure again, its common to miss a closing tag when your re-arranging your code, as it can easily get confusing. Once everything is wrapped with an opening and closing tag the way you intended it to be, then your CSS should behave in a much predictable fashion.
Hope this helps! Great try my friend! :)
Marked as helpful0@pharaohmakPosted over 2 years ago@Jorgus1710 Hey George, thank you for your feedback, it is much appreciated!
1 - @dumpdope1Posted over 2 years ago
Thank you so much for the information appreciate it.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord