nft-preview-card

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7Posted over 1 year ago

  Hi, Congratulations on solving this challenge!!!🎉🎉🎉🎉 I just went through your code, and have a few suggestions that I feel will help you.

  • Replace the h3 tag with an h1 tag to get rid of the accessibility issue.

  • In the CSS file, you don't have to mention width:100% to the body tag, because, for any element, if width is not mentioned, it takes up a 100% of its width by default.

  • In the body tag, replace the height:100vh with min-height:100vh, for better responsiveness.

  • For the p tag inside the div class="value" tag, instead of using font-weight, you can use the <b></b> to make the text bold, thereby requiring one less CSS line. <p><b>0.041 ETH</b></p>

  Hope this comment helps you. Please feel free to correct me if I said anything incorrect. Have a nice day!!

  Marked as helpful

  2