NFT-Preview-Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 9 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Gloria Gordon-Mensah•70

  @MhizGordonPosted 9 months ago

  @0xabdulkhalid thank you so much

  1

  

  Gloria Gordon-Mensah•70

  @MhizGordonPosted 9 months ago

  hi Abdul So i tried another challenge using the tips you gave me i realised i was a bit confused, so i do have a question Do you mean i must use <main> together with <div> or i shouldn't use div at all cos i think i understood as you saying i shouldn't use div at all i think i may have misunderstood you

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 9 months ago

  No @MhizGordon, main like elements are semantic they are used to define landmarks. You can use non-semantic elements like div inside semantic ones.

  I would greatly recommend this article Semantic HTML: What It Is and How to Use It Correctly, after reading through this one you could find answers for your doubts regarding using semantic elements with non-semantic ones.

  0

  

  Gloria Gordon-Mensah•70

  @MhizGordonPosted 9 months ago

  thank you@0xabdulkhalid i understamd now

  0
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hello there 👋 @MhizGordon@pianist161

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  Consider adding a min-height of 100vh to the body element so as to centralize your project.

  body { 
    min-height: 100vh;
    align-items: center;
    display: flex;
    justify-content: center;
  }
  
  

  I hope this suggestion is useful for future projects.

  Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! 🚀🌟.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0

  ---

  

  Gloria Gordon-Mensah•70

  @MhizGordonPosted 9 months ago

  thank you so much @Ezekiel225 for the browser extension recommendation and this comment as a whole.

  0