Travolgi 🍕• 31,420
@denielden
Posted
Hello Paul, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - remove all
margin
from card - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
0
Paul Janne• 80
@arudu
Posted
@denielden thank you for the help I see how you mean I feel your solutions so much cleaner in future projects I will take all this in consideration thank you again for all the advice and encouraging words!
0
Travolgi 🍕• 31,420
@denielden
Posted
@arudu you are welcome and keep it up :)
0