NFT-Preview Challege

Community feedback

• 

  Omar Mohy•670

  @omarmohy98Posted almost 3 years ago

  Good morning@sachdevavaibhav, wonderfully done! The code is remarkably responsive. Below is my feedback on potential improvements!

  1.) Instead of <div class="main"> , let's replace that with <main> element and make it the top level in your code. Doing so will give your code more semantic meaning, will allow screen readers to know THIS is your main content and Fix the issues appear in Accessibility Report.

  2.) Try to control images' width & height in style.css not in <img> element in your index.html.

  If you found my feedback helpful, please mark this comment as helpful. Wonderfully done. Happy coding!

  Marked as helpful

  1

  ---

  

  Vaibhav Sachdeva•70

  @sachdevavaibhavPosted almost 3 years ago

  @omarmohy22 Thank You for your feedback. I'll surely work on your suggestions and make the webpage more accessible.

  0

  

  Vaibhav Sachdeva•70

  @sachdevavaibhavPosted almost 3 years ago

  @omarmohy22 Hey! I have updated my solution. Can you please review it and give me feedback?

  0

  

  Omar Mohy•670

  @omarmohy98Posted almost 3 years ago

  @sachdevavaibhav your solution now become very good but I suggest that you read more about semantic elements it will help you in your challenge solution.

  Marked as helpful

  1

  

  Vaibhav Sachdeva•70

  @sachdevavaibhavPosted almost 3 years ago

  @omarmohy22 Thank You! I'll surely learn more about semantic html.😇

  0
• 

  Sameh•430

  @SamehCodePosted almost 3 years ago

  @sachdevavaibhav: oh man ur great. i hope i be like you once. if could anyone tell me some tips and tricks and some great content i could learn more and more from.

  1

  ---

  

  Vaibhav Sachdeva•70

  @sachdevavaibhavPosted almost 3 years ago

  @SamehCode Hey! I am glad to see you like my work. I am learning Web Dev from Colt Steele's Udemy Course. You can check that course out. Also check out Kevin Powell's YouTube channel for some fun CSS.

  0